Refactoring to drop deprecated usages in pyOpenSSL & drop Python 3.7 support
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adferrand
changed the title
pyOpenSSL & drop Python 3.7 support
alex
approved these changes
Sep 5, 2024
alex
added a commit
to alex/josepy
that referenced
this pull request
Sep 5, 2024
Without this, pyca/cryptography's downstream tests currently fail. The actual warning is being addressed in certbot#182
ohemorange
pushed a commit
that referenced
this pull request
Sep 5, 2024
Without this, pyca/cryptography's downstream tests currently fail. The actual warning is being addressed in #182
|
This should resolve advisories: (needs Python 3.7 dropped) |
|
Any movement on this? 👀 |
|
I opened #186 to drop Python 3.7 and fix security alerts. As for this PR in itself, we will likely do this and/or deprecate this library entirely as discussed at certbot/certbot#8322 and the comments on certbot/certbot#9993 in the next few months. We just need to map out what that transition will look like for the code in https://github.com/certbot/certbot. |
This was referenced Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
Caution: This PR introduces backward incompatible changes to the library. A major version of
josepyshould be issued when this PR is merged.Caution: Defensive PR on Certbot should be merged first -> certbot/certbot#9993
This PR removes the APIs deprecated by
pyopensslin version 24.2+.As a consequence, several changes of
josepypublic API are made:josepy.ComparableX509is removed since the underlying wrapped object is now objects fromcryptographyAPI (CertificateorCertificateSigningRequest) and these objects support equality checks.encode_csr,decode_csr,encode_certanddecode_certnow manipulates objects fromcryptographyAPIAside these changes, the support of Python 3.7 is dropped, given this PR will require a new major version anyway.